fix(neptune): validate IRI cell values in to_rdf_graph#3369
Merged
Conversation
Reject any DataFrame cell whose value cannot appear inside a SPARQL
IRIREF token (whitespace, control chars, or any of <>"{}|^`\), so
caller-supplied data cannot close the <...> token and inject arbitrary
SPARQL UPDATE syntax.
Validation runs before any write_sparql call and raises
InvalidArgumentValue identifying the offending column and row index.
Also relaxes four pre-existing test assertions in test_neptune_parsing
to tolerate gremlinpython >=3.8, which returns properties=[] where
prior versions returned properties=None.
…on 3.8 gremlinpython 3.8 removed the deprecated AnonymousTraversalSource.withGraph() method. Use the Graph().traversal() form (already used elsewhere in the same function) so to_property_graph works on both gremlinpython <3.8 and >=3.8.
EthanBunce
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
subject_column,predicate_column,object_column, andgraph_columnwhen present) inwr.neptune.to_rdf_graphagainst the SPARQL 1.1IRIREFgrammar before splicing into the generated UPDATE query. Cells containing whitespace, control characters, or any of<>"{}|^\\are rejected withInvalidArgumentValue, identifying the offending column and row index. Validation runs before anywrite_sparql` call, including across batches.tests/unit/test_neptune_parsing.pyto be compatible withgremlinpython >= 3.8, which now returnsproperties=[]where prior versions returnedproperties=None.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.